-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix network config module invalid src option error #52912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible#52911 Raise AnsibleError execption if the file path mentioned in src option in not found or failed to load
ganeshrn
requested review from
Qalthos,
rcarrillocruz,
trishnaguha,
NilashishC and
justjais
February 25, 2019 08:04
justjais
approved these changes
Feb 25, 2019
ansibot
added
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
networking
Network category
support:network
This issue/PR relates to code supported by the Ansible Network Team.
traceback
This issue/PR includes a traceback.
labels
Feb 25, 2019
ganeshrn
commented
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justjais Thank you for review
chrisvanheuveln
added a commit
to chrisvanheuveln/ansible
that referenced
this pull request
Feb 27, 2019
PR ansible#52912 fixed this already.
ganeshrn
pushed a commit
that referenced
this pull request
Feb 28, 2019
…es (#52745) * network.py:ActionModule:run: does not honor _handle_src_option failures PR #50301 moved template error handling out of run() and into its own method in `_handle_src_option`; however, after the change run() ignores the return value so any errors are ignored. Reproduceable with `nxos_config/tests/common/src_invalid.yaml` Verified fix with `nxos_config/tests/common/src_*` tests. Ref: 71113ee#diff-7477bf046013758366cc85b06f90709aR43 * nxos_config/tests/common/src_basic: Updated to test with src This test was not actually testing with `src:` as it should have. * Revert 412d7e change to plugins/action/network.py PR #52912 fixed this already. * nxos_config: fix src_invalid test
trishnaguha
pushed a commit
to trishnaguha/ansible
that referenced
this pull request
Apr 1, 2019
…es (ansible#52745) * network.py:ActionModule:run: does not honor _handle_src_option failures PR ansible#50301 moved template error handling out of run() and into its own method in `_handle_src_option`; however, after the change run() ignores the return value so any errors are ignored. Reproduceable with `nxos_config/tests/common/src_invalid.yaml` Verified fix with `nxos_config/tests/common/src_*` tests. Ref: ansible@71113ee#diff-7477bf046013758366cc85b06f90709aR43 * nxos_config/tests/common/src_basic: Updated to test with src This test was not actually testing with `src:` as it should have. * Revert 412d7e change to plugins/action/network.py PR ansible#52912 fixed this already. * nxos_config: fix src_invalid test (cherry picked from commit d69239c)
abadger
pushed a commit
that referenced
this pull request
Apr 4, 2019
…es (#52745) * network.py:ActionModule:run: does not honor _handle_src_option failures PR #50301 moved template error handling out of run() and into its own method in `_handle_src_option`; however, after the change run() ignores the return value so any errors are ignored. Reproduceable with `nxos_config/tests/common/src_invalid.yaml` Verified fix with `nxos_config/tests/common/src_*` tests. Ref: 71113ee#diff-7477bf046013758366cc85b06f90709aR43 * nxos_config/tests/common/src_basic: Updated to test with src This test was not actually testing with `src:` as it should have. * Revert 412d7e change to plugins/action/network.py PR #52912 fixed this already. * nxos_config: fix src_invalid test (cherry picked from commit d69239c)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
cisco
Cisco technologies
core_review
In order to be merged, this PR must follow the core review workflow.
ios
Cisco IOS community
networking
Network category
support:network
This issue/PR relates to code supported by the Ansible Network Team.
traceback
This issue/PR includes a traceback.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #52911
Raise AnsibleError exception if the file
path mentioned in src option is not found or
failed to load the file
ISSUE TYPE
COMPONENT NAME
ios_config
ADDITIONAL INFORMATION
Before:
After: