Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hpe3par document type #52992

Merged
merged 2 commits into from
Mar 1, 2019
Merged

hpe3par document type #52992

merged 2 commits into from
Mar 1, 2019

Conversation

gundalow
Copy link
Contributor

@gundalow gundalow commented Feb 26, 2019 •
edited

SUMMARY

Add in type documentation that was missed in #39656

Also version_added should be a string.

ISSUE TYPE
  • Docs Pull Request

@gundalow gundalow marked this pull request as ready for review February 26, 2019 15:08
@gundalow gundalow mentioned this pull request Feb 26, 2019
Merged
@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/kubevirt/kubevirt_template.py:0:0: E325 Argument 'resource_definition' in argument_spec defines type as <function list_dict_str at 0x7fc871654c80> but documentation defines type as 'str'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

cc @farhan7500 @gautamphegde
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. storage support:community This issue/PR relates to code supported by the Ansible community. labels Feb 26, 2019
thedoubl3j
thedoubl3j approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, sorry we missed that.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 26, 2019
@farhan7500
Copy link
Contributor

Thanks!

Will ensure that these changes are taken care of in the future PRs

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 27, 2019
@acozine @gundalow
Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py
d8facf8 
Co-Authored-By: gundalow <john@johnrbarker.com>
@acozine acozine merged commit 6e74816 into ansible:devel Mar 1, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gundalow @ansibot @farhan7500 @acozine @thedoubl3j