Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirt: Fix cloud_init in kubevirt_vm #52999

Merged
merged 1 commit into from
Mar 1, 2019
Merged

kubevirt: Fix cloud_init in kubevirt_vm #52999

merged 1 commit into from
Mar 1, 2019

Conversation

machacekondra
Copy link
Contributor

SUMMARY

Cloud init definition must be after other volumes definition, so it's not used as boot disk.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubevirt_vm

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/kubevirt/kubevirt_template.py:0:0: E325 Argument 'resource_definition' in argument_spec defines type as <function list_dict_str at 0x7f605866e510> but documentation defines type as 'str'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

cc @kubevirt @mmazur @pkliczewski
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 26, 2019
@mmazur
Copy link
Contributor

mmazur commented Feb 27, 2019

+1

@pkliczewski
Copy link

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Feb 27, 2019
@resmo
Copy link
Contributor

resmo commented Feb 27, 2019

shipit

@gundalow gundalow merged commit b54f279 into ansible:devel Mar 1, 2019
@gundalow
Copy link
Contributor

gundalow commented Mar 1, 2019

@machacekondra Thank you for the fix
@mmazur @pkliczewski @resmo Thank you for the reviews.

@machacekondra If you'd like to see this fixed in the next Ansible 2.7 release please raise a backport PR with a changelog/fragment by following https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@pkliczewski pkliczewski pkliczewski approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@machacekondra @ansibot @mmazur @pkliczewski @resmo @gundalow