Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix junos terminal regex for cluster srx devices #53006

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Fix junos terminal regex for cluster srx devices #53006

merged 2 commits into from
Mar 7, 2019

Conversation

ganeshrn
Copy link
Member

SUMMARY

Fixes #50726

  • Modify junos terminal regex to match for
    string {primary:node0} which is also part of the
    prompt.
  • Modify network_cli connection plugin to ignore
    multiple prompt matched lines.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/terminal/junos.py
plugins/connection/network_cli.py

ADDITIONAL INFORMATION

@ganeshrn
Fix junos terminal regex for cluster srx devices
2f6cfea 
Fixes ansible#50726

*  Modify junos terminal regex to match for
   string `{primary:node0}` which is also part of the
   prompt.
*  Modify network_cli connection plugin to ignore
   multiple prompt matched lines.
@ganeshrn ganeshrn mentioned this pull request Feb 26, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

cc @NilashishC @Qalthos @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 26, 2019
@ganeshrn ganeshrn removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 27, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_triage Needs a first human triage before being processed. labels Mar 4, 2019
@ganeshrn ganeshrn merged commit 7a36c7a into ansible:devel Mar 7, 2019
@ganeshrn ganeshrn deleted the junos_terminal_plugin_cluster_fix branch March 7, 2019 08:22
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@privateip privateip Awaiting requested review from privateip

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

@NilashishC NilashishC Awaiting requested review from NilashishC

@trishnaguha trishnaguha Awaiting requested review from trishnaguha

@justjais justjais Awaiting requested review from justjais

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extraneous data in junos_command output with SRX cluster
3 participants
@ganeshrn @ansibot @Qalthos