Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced outdate release info with checkmarks #53016

Merged
merged 1 commit into from
Mar 4, 2019
Merged

replaced outdate release info with checkmarks #53016

merged 1 commit into from
Mar 4, 2019

Conversation

samccann
Copy link
Contributor

SUMMARY

Partially addresses #52997

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

ADDITIONAL INFORMATION

@samccann samccann added networking Network category docs This issue/PR relates to or includes documentation. affects_2.8 This issue/PR affects Ansible v2.8 labels Feb 26, 2019
@samccann samccann added this to Docsite work in Ansible-maintained Collections Documentation via automation Feb 26, 2019
@samccann
Copy link
Contributor Author

The current table is getting wide, and has version details that aren't required anymore. Here is the existing version:

image

And here is what this PR makes it look like now:

image

@ansibot
Copy link
Contributor

ansibot commented Feb 26, 2019

cc @acozine
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 26, 2019
@acozine
Copy link
Contributor

acozine commented Feb 26, 2019

I like this look - the table is more readable and now we can add more connection types as necessary.

gundalow
gundalow approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's great. Much more readable.

@samccann samccann changed the title replaced outdate release info with checkmarks [WIP] replaced outdate release info with checkmarks Feb 26, 2019
@samccann
Copy link
Contributor Author

..making it wip for a day or two to ensure the networking folks have a look before we merge

@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Feb 26, 2019
@samccann samccann changed the title [WIP] replaced outdate release info with checkmarks replaced outdate release info with checkmarks Feb 28, 2019
@samccann samccann removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Feb 28, 2019
@samccann
Copy link
Contributor Author

got network team approval so removing the wip status. this PR is ready to merge

@acozine acozine merged commit d12e358 into ansible:devel Mar 4, 2019
Ansible-maintained Collections Documentation automation moved this from Docsite work to Done Mar 4, 2019
@samccann samccann deleted the network_platform_52997 branch May 6, 2019 14:55
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Ansible-maintained Collections Docume...
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samccann @ansibot @acozine @gundalow