Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: vmware_vm_inventory using vaulted config #53048

Merged
merged 2 commits into from Mar 4, 2019
Merged

VMware: vmware_vm_inventory using vaulted config #53048

merged 2 commits into from Mar 4, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY

Adds documentation about using vaulted inventory cofiguration file
for vmware_vm_inventory plugin.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/vmware/vmware_inventory.rst

@Akasurde
Copy link
Member Author

cc @angystardust As we discussed on IRC, here is document to describing vaulted inventory file.

@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 27, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

The test ansible-test sanity --test rstcheck [explain] failed with 2 errors:

docs/docsite/rst/vmware/vmware_inventory.rst:60:0: (bash) `$ ansible-inventory -i <filename>.vmware.yml --list --vault-password-file=</path/to/vault_password_file>'
docs/docsite/rst/vmware/vmware_inventory.rst:60:0: (bash) syntax error near unexpected token `newline'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 27, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 27, 2019
@angystardust
Copy link
Contributor

Thanks @Akasurde for rembering about my question!
So, I suppose that right now, ansible dynamic inventory is only able to decrypt the whole .yml file instead of decrypting only the password parameter, right?
If I’m right, in the latest ansible releases, it’s possibile to encrypt a single line inside a static inventory so it would be great if dynamic inventories could also do that (for cosistency and convenience)

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 27, 2019
@Akasurde
VMware: vmware_vm_inventory using vaulted config
ebd002f 
Adds documentation about using vaulted inventory cofiguration file
for vmware_vm_inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
acozine
acozine reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Akasurde - I added a couple of small suggestions.

docs/docsite/rst/vmware/vmware_inventory.rst Outdated Show resolved Hide resolved
docs/docsite/rst/vmware/vmware_inventory.rst Outdated Show resolved Hide resolved
docs/docsite/rst/vmware/vmware_inventory.rst Outdated Show resolved Hide resolved
docs/docsite/rst/vmware/vmware_inventory.rst Outdated Show resolved Hide resolved
@Akasurde
Review comments
065e058 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@acozine acozine merged commit c948849 into ansible:devel Mar 4, 2019
@Akasurde Akasurde deleted the vault_inventory branch March 5, 2019 06:15
@Akasurde
Copy link
Member Author

Akasurde commented Mar 5, 2019

@acozine @samccann Thanks for the review.

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@samccann samccann samccann left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akasurde @ansibot @angystardust @acozine @samccann