Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utilities: Clean up parameter types and add seealso #53063

Merged
merged 3 commits into from
Mar 6, 2019
Merged

utilities: Clean up parameter types and add seealso #53063

merged 3 commits into from
Mar 6, 2019

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Feb 27, 2019 •
edited

SUMMARY

This PR includes:

  • Added parameter types to documentation
  • Improve documentation
  • Add seealso: references to other modules
  • Fix copyright statements
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

utilities modules

@ansibot

This comment has been minimized.

Sign in to view
@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

cc @AnderEnder @bcoca @gregswift @jarv @jhoekx @linuxdynasty
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 deprecated This issue/PR relates to a deprecated module. docs This issue/PR relates to or includes documentation. include_role module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utilities Utilities category labels Feb 27, 2019
@dagwieers dagwieers force-pushed the utilities-params branch 2 times, most recently from d11ccf1 to ec6634b Compare February 27, 2019 14:05
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 27, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 27, 2019

cc @acozine
click here for bot help

@ansibot ansibot added inventory Inventory category and removed owner_pr This PR is made by the module's maintainer. labels Feb 27, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 27, 2019
gundalow
gundalow reviewed Feb 27, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the seealso

lib/ansible/modules/utilities/helper/meta.py Show resolved Hide resolved
lib/ansible/modules/utilities/logic/debug.py Show resolved Hide resolved
@dagwieers
Copy link
Contributor Author

@gundalow Can we get this merged ? I had to rebase due to another conflict.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2019
@dagwieers
Copy link
Contributor Author

@mattclay: I don't see a real cause, but I did find:

./runme.sh: line 25: perl: command not found

gundalow
gundalow approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge once CI is green

@mattclay
Copy link
Member

mattclay commented Mar 6, 2019

@dagwieers Recent changes to the assert integration test are responsible:

ansible/test/integration/targets/assert/runme.sh

Lines 25 to 26 in c0a4cf2

perl -pi -e 's/ *$//s' "${OUTFILE}.${testname}.stdout"
perl -pi -e 's/ *$//s' "${OUTFILE}.${testname}.stderr"

Those changes should not have been merged.

Someone needs to update the test to work without requiring perl.

@ansibot ansibot removed the needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) label Mar 6, 2019
@mattclay
Copy link
Member

mattclay commented Mar 6, 2019

@dagwieers I've fixed the assert integration test and restarted tests for this PR.

@dagwieers dagwieers merged commit f471916 into ansible:devel Mar 6, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@acozine acozine Awaiting requested review from acozine

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 deprecated This issue/PR relates to a deprecated module. docs This issue/PR relates to or includes documentation. include_role inventory Inventory category module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utilities Utilities category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @ansibot @mattclay @gundalow