get_url: return no change in check mode when checksum matches #53070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tony Finch <dot@dotat.at>
|
shipit |
ansibot
added
affects_2.8
ptux
reviewed
Feb 28, 2019
| if module.check_mode: | ||
| if os.path.exists(tmpsrc): | ||
| os.remove(tmpsrc) | ||
| result['changed'] = ('checksum_dest' not in result or |
There was a problem hiding this comment.
You'd better add a test for 'checksum_dest' not in result.
There was a problem hiding this comment.
I think the existing check_mode tests already cover that case, or have I missed something?
There was a problem hiding this comment.
You are right.
the following test case covers your code.
name: test HTTP HEAD request for file in check mode
|
shipit |
ansibot
added
shipit
|
@fanf2 Thank you for this fix and for extending the tests @fanf2 If you'd like to see this fixed in the next Ansible 2.7 release please raise a backport PR with a changelog/fragment by following https://docs.ansible.com/ansible/devel/community/development_process.html#making-your-pr-merge-worthy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In check_mode,
get_urldoes not compare the checksum with the destination file, so it produces spuriouschangedresults which turn out to be green when check_mode is False.This change moves the check_mode logic a little bit later in get_url so that the destination file checksum is available for comparison with the source file checksum.
ISSUE TYPE
COMPONENT NAME
get_url
ADDITIONAL INFORMATION
I have updated the get_url test with a case that illustrates this problem and fix.