Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_dsc - Add argument validation and other fixes #53093

Merged
merged 2 commits into from
Mar 5, 2019
Merged

win_dsc - Add argument validation and other fixes #53093

merged 2 commits into from
Mar 5, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Refactor of the win_dsc module that adds the following;

  • Parameter validation
  • Parameter invocation return
  • Return Verbose logs for both the Test and Set methods
  • Support for Hashtables/MSFT_KeyValuePair values
  • Validation on sub dicts (CimInstances)
  • Revamp of the tests to be simpler and touch less system resources
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_dsc

@jborean93 jborean93 mentioned this pull request Feb 28, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

cc @acozine @dagwieers @if-meaton @jhawkesworth @mattclay @nitzmahone @trondhindenes
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Feb 28, 2019
acozine
acozine reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good - I made a couple of small suggestions.

docs/docsite/rst/user_guide/windows_dsc.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/windows_dsc.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/windows_dsc.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/windows_dsc.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/windows_dsc.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/windows_dsc.rst Outdated Show resolved Hide resolved
lib/ansible/modules/windows/win_dsc.py Outdated Show resolved Hide resolved
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 4, 2019
@jborean93
Copy link
Contributor Author

Thanks @acozine for the review, should be fixed.

@jborean93
Copy link
Contributor Author

Merging this in so we get something running in devel.

@jborean93 jborean93 merged commit 6b294ea into ansible:devel Mar 5, 2019
@jborean93 jborean93 deleted the win_dsc-arg-spec branch March 5, 2019 20:50
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @acozine