Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_chocolatey_source - fix state=disabled with no source #53097

Merged
merged 1 commit into from
Mar 5, 2019
Merged

win_chocolatey_source - fix state=disabled with no source #53097

merged 1 commit into from
Mar 5, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

The ability to disable an existing Chocolatey source without setting the source itself was documented but never worked. This PR fixes that issue and adds tests cases for the module.

Fixes #50133

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_chocolatey_source

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

cc @dagwieers @if-meaton @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Feb 28, 2019
@jborean93 jborean93 merged commit be7768e into ansible:devel Mar 5, 2019
@jborean93 jborean93 deleted the win_chocolatey_source-disable branch March 5, 2019 04:18
jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 5, 2019
@jborean93
win_chocolatey_source - fix state=disabled with no source (ansible#53097
eb173e6 
)

(cherry picked from commit be7768e)
@jborean93 jborean93 mentioned this pull request Mar 5, 2019
Merged
@jborean93
Copy link
Contributor Author

Backport PR to stable-2.7 #53309

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2019
abadger pushed a commit that referenced this pull request Mar 6, 2019
@jborean93 @abadger
win_chocolatey_source - fix state=disabled with no source (#53097)
8bb830c 
(cherry picked from commit be7768e)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in win_chocolatey_source module
3 participants
@jborean93 @ansibot @sivel