Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zabbix_action] Refactoring the argument spec #53106

Merged
merged 3 commits into from
Mar 1, 2019
Merged

[zabbix_action] Refactoring the argument spec #53106

merged 3 commits into from
Mar 1, 2019

Conversation

rubentsirunyan
Copy link
Contributor

SUMMARY
  • Added nested arguments as elemets and options.
  • Added requirements and mutual dependencies for the second level arguments.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zabbix_action

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

cc @D3DeFi @K-dot @eikef
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. monitoring Monitoring category needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. zabbix Zabbix community and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 28, 2019
D3DeFi
D3DeFi approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, that is definitely a very nice addition to argument spec. Thank you for your work @rubentsirunyan ! :)
shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 1, 2019
@ansibot ansibot merged commit 832a669 into ansible:devel Mar 1, 2019
@rubentsirunyan rubentsirunyan deleted the zabbix-action-arg-spec branch March 1, 2019 13:41
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@D3DeFi D3DeFi D3DeFi approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. monitoring Monitoring category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rubentsirunyan @ansibot @D3DeFi