Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing mediatype default value #53114

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Fixing mediatype default value #53114

merged 2 commits into from
Mar 1, 2019

Conversation

rubentsirunyan
Copy link
Contributor

SUMMARY

Changed the default value of media_type to be set to 'all'

Fixes #52740

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zabbix_action

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 28, 2019

cc @D3DeFi @K-dot @eikef
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. monitoring Monitoring category needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. zabbix Zabbix community labels Feb 28, 2019
@rubentsirunyan rubentsirunyan marked this pull request as ready for review February 28, 2019 13:30
D3DeFi
D3DeFi approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work as expected, tested with zbx4.0
-label needs_triage
shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 1, 2019
@ansibot ansibot merged commit 1b338f9 into ansible:devel Mar 1, 2019
@rubentsirunyan rubentsirunyan deleted the zabbix-action-mediatype branch March 1, 2019 13:41
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@D3DeFi D3DeFi D3DeFi approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. monitoring Monitoring category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. zabbix Zabbix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zabbix_action: operation media type cannot be unset
3 participants
@rubentsirunyan @ansibot @D3DeFi