Added support for infoblox member object #53174
Merged
+676
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krisvasudevan this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibot
added
affects_2.8
ansibot
added
core_review
|
The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test |
ansibot
added
needs_revision
|
The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test |
|
The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test The test |
|
The test The test The test The test The test The test The test The test The test The test The test The test The test The test |
|
The test The test The test The test The test The test The test The test |
ansibot
removed
needs_triage
|
The test The test The test The test The test The test The test |
justjais
suggested changes
Mar 5, 2019
| @@ -31,7 +31,6 @@ | |||
| from ansible.module_utils._text import to_native | |||
| from ansible.module_utils.six import iteritems | |||
| from ansible.module_utils._text import to_text | |||
| from ansible.module_utils.basic import env_fallback | |||
There was a problem hiding this comment.
@krisvasudevan why have you removed this line?
| @@ -55,25 +54,20 @@ | |||
| NIOS_SRV_RECORD = 'record:srv' | |||
| NIOS_NAPTR_RECORD = 'record:naptr' | |||
| NIOS_TXT_RECORD = 'record:txt' | |||
| NIOS_NSGROUP = 'nsgroup' | |||
There was a problem hiding this comment.
Seems like your branch is not updated, else why have you removed the support for the existing modules.
|
|
||
| NIOS_PROVIDER_SPEC = { | ||
| 'host': dict(fallback=(env_fallback, ['INFOBLOX_HOST'])), |
There was a problem hiding this comment.
env_fallback module is used when user has defined INFOBLOX_HOST value under env variable. Please undo these changes.
| @@ -114,8 +108,8 @@ def normalize_extattrs(value): | |||
| extattrs: { | |||
| key: { | |||
| value: <value> | |||
| } | |||
| } | |||
| } | |||
| @@ -222,29 +238,24 @@ def run(self, ib_obj_type, ib_spec): | |||
| # get object reference | |||
| ib_obj_ref, update, new_name = self.get_object_ref(self.module, ib_obj_type, obj_filter, ib_spec) | |||
|
|
|||
| proposed_object = {} | |||
There was a problem hiding this comment.
There's seems to be many changes that I am unable to understand, from this down below can u comment that why you have made all the changes. Thanks
justjais
reviewed
Mar 11, 2019
|
@krisvasudevan please try to fix all the shippable errors. |
mattclay
added
the
ci_verified
|
The test The test |
ansibot
removed
the
ci_verified
|
The test The test The test The test The test The test The test The test The test The test |
|
@krisvasudevan please update the PR with the unit test case, rest of changes looks fine. Once done, I shall approve and merge the PR. |
|
The test The test The test The test The test The test The test The test |
|
The test The test The test The test The test The test The test The test |
mattclay
added
the
ci_verified
|
The test The test The test The test The test The test The test The test |
ansibot
removed
the
ci_verified
|
The test The test The test The test The test The test The test |
|
The test |
justjais
approved these changes
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support for member object. It supports adding and/or removes Infoblox NIOS servers.
ISSUE TYPE
COMPONENT NAME
nios_member
ADDITIONAL INFORMATION
The module supports various parameters that enable adding a standalone/HA member. It also supports both IPv4 and IPv6.
Changes had to be made to api.py file in order to normalize the input parameters. The member_normalize function will remove any arguments that are set to None since WAPI will error on that condition.