Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate-modules improve empty version_added handling #53177

Merged
merged 2 commits into from
Mar 1, 2019
Merged

validate-modules improve empty version_added handling #53177

merged 2 commits into from
Mar 1, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Mar 1, 2019

SUMMARY

validate-modules improve empty version_added handling

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/sanity/validate-modules/main.py

ADDITIONAL INFORMATION

@sivel sivel requested a review from mattclay March 1, 2019 15:50
@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2019

cc @gundalow @mattclay
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 1, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 1, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:164:1: A102 Remove since "lib/ansible/modules/cloud/kubevirt/kubevirt_cdi_upload.py" passes "E203" test

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 1, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 1, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 1, 2019
@sivel sivel merged commit f0a63e7 into ansible:devel Mar 1, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sivel @ansibot @mattclay