Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DevTest Lab ARM Template facts #53196

Merged
merged 4 commits into from
Mar 4, 2019
Merged

Adding DevTest Lab ARM Template facts #53196

merged 4 commits into from
Mar 4, 2019

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Mar 2, 2019

SUMMARY

Adding DTL ARM Template facts module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_devtestlabarmtemplate_facts

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 2, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 2, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 2, 2019

@Madhura-CSI @brusMX @caohai @devigned @gustavomcarmo @haroldwongms @iphilpot @julienstroheker @lmazuel @obsoleted @sozercan @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibleazurebot ansibleazurebot mentioned this pull request Mar 3, 2019
Closed
@Fred-sun
Copy link
Contributor

Fred-sun commented Mar 4, 2019

@yungezz @yuwzho

yungezz
yungezz reviewed Mar 4, 2019
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_devtestlabarmtemplate_facts.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/azure/azure_rm_devtestlabarmtemplate_facts.py
module: azure_rm_devtestlabarmtemplate_facts
version_added: "2.8"
short_description: Get Azure Arm Template facts.
description:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arm to full name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to "Azure DevTest Lab ARM Template"

lib/ansible/modules/cloud/azure/azure_rm_devtestlabarmtemplate_facts.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/azure/azure_rm_devtestlabarmtemplate_facts.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_triage Needs a first human triage before being processed. community_review In order to be merged, this PR must follow the community review workflow. labels Mar 4, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 4, 2019
yungezz
yungezz reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code itself looks good. Just didn't get difference betwen armtemplate_facts and artifactsource_facts. can these 2 combine as one?

lib/ansible/modules/cloud/azure/azure_rm_devtestlabarmtemplate_facts.py
description:
- The name of the lab.
required: True
artifact_source_name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it need artifact_source_name? is this copied from artifact source facts module?

Copy link
Contributor Author

@zikalino zikalino Mar 4, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's subresourcece of artifact_source.
Artifacts source is a GitHub/VSO repository, which can contain:

  • artifacts
  • ARM templates
    so these two are subresources of artifacts source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i return artifacts_source_name just for consistency.
somebody may query ARM templates from 2 artifact sources and then combine the lists for instance.

yungezz
yungezz approved these changes Mar 4, 2019
View reviewed changes
lib/ansible/modules/cloud/azure/azure_rm_devtestlabarmtemplate_facts.py
lab_name=self.lab_name,
artifact_source_name=self.artifact_source_name)
self.log("Response : {0}".format(response))
except CloudError as e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we fail when list get null?

@zikalino zikalino merged commit b547376 into ansible:devel Mar 4, 2019
@zikalino zikalino deleted the dtl-arm-template-facts branch March 4, 2019 09:18
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yungezz yungezz yungezz approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zikalino @ansibot @Fred-sun @yungezz