Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_csr: improve subject validation #53198

Merged
merged 4 commits into from
Mar 7, 2019
Merged

openssl_csr: improve subject validation #53198

merged 4 commits into from
Mar 7, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Improves subject validation for openssl_csr. Fixes #53167.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_csr

@felixfontein felixfontein mentioned this pull request Mar 2, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Mar 2, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Mar 2, 2019
@Shaps
Copy link
Contributor

Shaps commented Mar 7, 2019

Looks good to me.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 7, 2019
@gundalow gundalow merged commit b2e992c into ansible:devel Mar 7, 2019
@felixfontein felixfontein deleted the openssl_csr-country-name branch March 7, 2019 17:23
@felixfontein
Copy link
Contributor Author

@Shaps thanks for reviewing!
@gundalow thanks for merging!

@felixfontein felixfontein mentioned this pull request Mar 7, 2019
Merged
felixfontein added a commit to felixfontein/ansible that referenced this pull request Mar 7, 2019
@felixfontein
openssl_csr: improve subject validation (ansible#53198)
262477d 
* Improve subject field validation.

* Add country name idempotency test.

* Add failed country name test.

* Add changelog.

(cherry picked from commit b2e992c)
abadger pushed a commit that referenced this pull request Mar 11, 2019
@felixfontein @abadger
openssl_csr: improve subject validation (#53198)
c4748fd 
* Improve subject field validation.

* Add country name idempotency test.

* Add failed country name test.

* Add changelog.

(cherry picked from commit b2e992c)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idempotency test failed for openssl_csr (Country Name)
4 participants
@felixfontein @ansibot @Shaps @gundalow