Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] openssl_certificate, fixed has_expired to check the cert expiration date #53203

Merged
merged 4 commits into from
Mar 4, 2019
Merged

[2.7] openssl_certificate, fixed has_expired to check the cert expiration date #53203

merged 4 commits into from
Mar 4, 2019

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Mar 2, 2019 •
edited

SUMMARY

Backport of #47508 and #53168 to stable-2.7: fixes behavior of has_expired.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_csr

@ansibot
Copy link
Contributor

ansibot commented Mar 2, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 2, 2019
@felixfontein
Copy link
Contributor Author

Looks like this has to wait until selfsigned_not_after has been fixed. (This doesn't seem to be the bug described in #46196, but a Python 3 bytes string problem.)

@felixfontein felixfontein mentioned this pull request Mar 2, 2019
Closed
s3lph and others added 3 commits March 2, 2019 15:28
@s3lph @felixfontein
Type error in openssl_certificate (ansible#47508)
682e1f0 
* Fixed ansible#47505: Type error in openssl_certificate
* Use to_bytes instead of str.encode in SelfSignedCertificate. Updates ansible#47508
* Use to_bytes instead of str.encode in OwnCACertificate
* Added integration tests for openssl_certificate: selfsigned_not_before/after and ownca_not_before/after

(cherry picked from commit 5b1c685)
@Shaps @felixfontein
openssl_certificate, fixed has_expired to check the cert expiration d…
cefad5b 
…ate (ansible#53168)

(cherry picked from commit d5d92e4)
@felixfontein
Use fixed timestamp in past instead of relative time (relative times …
f6b58c3 
…are a feature of devel).
@felixfontein
Copy link
Contributor Author

Ah, that already has been partially fixed in #47508, but never backported. Including a backport in this PR.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 2, 2019
@abadger abadger merged commit 597db1d into ansible:stable-2.7 Mar 4, 2019
@abadger
Copy link
Contributor

abadger commented Mar 4, 2019

Thanks felixfontein! Merged for 2.7.9

@felixfontein felixfontein deleted the backport/2.7/53168 branch March 4, 2019 17:03
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@felixfontein @ansibot @abadger @sivel @s3lph @Shaps