Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7] docker_swarm_service: fix problem with UpdateConfig on certain docker daemons #53224

Merged
merged 2 commits into from
Mar 4, 2019
Merged

[2.7] docker_swarm_service: fix problem with UpdateConfig on certain docker daemons #53224

merged 2 commits into from
Mar 4, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

This PR is not a backport, but tries to fix something which no longer applies to devel. The change is similiar to what happened in devel. @hannseman @dariko @jwitko I would appreciate if you could review this!

Fixes part of #53223.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_swarm_service

@ansibot
Copy link
Contributor

ansibot commented Mar 3, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @danihodovic @kassiansun @tbouvet
click here for bot help

@ansibot ansibot added affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 3, 2019
@felixfontein felixfontein mentioned this pull request Mar 3, 2019
Closed
hannseman
hannseman approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@hannseman hannseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 3, 2019
@abadger abadger merged commit 122e73d into ansible:stable-2.7 Mar 4, 2019
@abadger
Copy link
Contributor

abadger commented Mar 4, 2019

Merged for the 2.7.9 release.

@felixfontein
Copy link
Contributor Author

@hannseman thanks for reviewing!
@abadger thanks for merging!

@felixfontein felixfontein deleted the docker_swarm_service-2.7-UpdateConfig branch March 4, 2019 17:02
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hannseman hannseman hannseman approved these changes

Assignees
No one assigned
Labels
affects_2.7 This issue/PR affects Ansible v2.7 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @abadger @hannseman