Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_swarm_service: rename return variable to swarm_service #53229

Merged
merged 3 commits into from
Mar 6, 2019
Merged

docker_swarm_service: rename return variable to swarm_service #53229

merged 3 commits into from
Mar 6, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

As discussed in #51939, renaming the return variable to swarm_service.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

docker_swarm_service

@ansibot
Copy link
Contributor

ansibot commented Mar 3, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @danihodovic @dariko @hannseman @jwitko @kassiansun @tbouvet
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 3, 2019
@felixfontein felixfontein force-pushed the docker_swarm_service-fix-return-values branch from ff8a330 to 28d0fda Compare March 3, 2019 15:53
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. test This PR relates to tests. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 3, 2019
@felixfontein
Copy link
Contributor Author

@hannseman @jwitko please say something if you don't like this change :) (the new name was suggested by @dariko, see here and below). Or shipit it if you like it :)

hannseman
hannseman approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@hannseman hannseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 3, 2019
@felixfontein
Copy link
Contributor Author

@abadger I assume you're still the release manager for Ansible 2.7.x. Can you take a look at this PR and say if it is ok from your point of view? Otherwise it doesn't make sense to merge it in this form (and backport it to stable-2.7).

jwitko
jwitko approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@jwitko jwitko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein
Copy link
Contributor Author

After talking to @abadger, I've added a remark that the old name will stay for Ansible 2.7.x. I will add that in the backport PR once this is merged.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core community_review In order to be merged, this PR must follow the community review workflow. labels Mar 4, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 4, 2019
@felixfontein
Copy link
Contributor Author

ready_for_review

@WojciechowskiPiotr
Copy link
Contributor

This change does not require the cycle of four releases of maintaining old name?

@felixfontein
Copy link
Contributor Author

This is kind of special, since the return value never worked as documented, we can consider this feature as "not really used". Keeping it working in 2.7.x is a courtesy to people who figured out that the result is called differently (but apparently didn't report this discrepancy).

@WojciechowskiPiotr
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 5, 2019
@gundalow gundalow merged commit 61abbfc into ansible:devel Mar 6, 2019
@felixfontein felixfontein deleted the docker_swarm_service-fix-return-values branch March 6, 2019 17:17
@felixfontein felixfontein mentioned this pull request Mar 6, 2019
Merged
@felixfontein
Copy link
Contributor Author

@hannseman @jwitko @WojciechowskiPiotr thanks for your feedback!
@gundalow thanks for merging!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Mar 6, 2019
@felixfontein
docker_swarm_service: rename return variable to swarm_service (ansibl…
ef8c9f3 
…e#53229)

* Rename return variable to swarm_service.

* Add changelog.

* Add that old name will stay in Ansible 2.7.x.

(cherry picked from commit 61abbfc)
@felixfontein felixfontein mentioned this pull request Mar 6, 2019
Merged
abadger pushed a commit that referenced this pull request Mar 6, 2019
@felixfontein @abadger
[2.7] docker_swarm_service: rename return variable to swarm_service (#…
3380def 
…53408)

* docker_swarm_service: rename return variable to swarm_service (#53229)

* Rename return variable to swarm_service.

* Add changelog.

* Add that old name will stay in Ansible 2.7.x.

(cherry picked from commit 61abbfc)

* Keep old variable for backwards compatibility.
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hannseman hannseman hannseman approved these changes

@jwitko jwitko jwitko approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@felixfontein @ansibot @WojciechowskiPiotr @hannseman @jwitko @gundalow