Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an incorrect function call in a documentation example. #53233

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix an incorrect function call in a documentation example. #53233

merged 1 commit into from
Mar 4, 2019

Conversation

chrisgavin
Copy link
Contributor

SUMMARY

The set_variable function takes the name of the inventory object that the variable is being set on as a mandatory positional argument. See the definition here.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Docs

@ansibot
Copy link
Contributor

ansibot commented Mar 3, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 3, 2019
Akasurde
Akasurde approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 4, 2019
@acozine
Copy link
Contributor

acozine commented Mar 4, 2019

Thanks @chrisgavin for catching and fixing that error, and especially for the link to the definition. Context really helps with documentation fixes, and this PR may help others figure things out in future.

@acozine acozine merged commit 4304268 into ansible:devel Mar 4, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chrisgavin @ansibot @acozine @Akasurde @s-hertel