Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mso_stae_subnet: Fix various issues #53239

Merged
merged 1 commit into from
Mar 4, 2019
Merged

mso_stae_subnet: Fix various issues #53239

merged 1 commit into from
Mar 4, 2019

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Mar 4, 2019 •
edited

SUMMARY

This PR includes:

  • Rename 'ip' to 'subnet' as that's what we're managing
  • Use the correct module name in the examples
  • Small improvement in logic

This PR requires #53242

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

mso_schema_template_anp_epg_subnet

@dagwieers
mso_stae_subnet: Fix various issues
11f9348 
This PR includes:
- Rename 'ip' to 'subnet' as that's what we're managing
- Use the correct module name in the examples
- Small improvement in logic
@ansibot
Copy link
Contributor

ansibot commented Mar 4, 2019

cc @brunocalogero @jmcgill298 @mtorelli @rsmeyers @schunduri @smnmtzgr
click here for bot help

@ansibot ansibot added aci Cisco ACI community affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 4, 2019
@dagwieers dagwieers added the cisco Cisco technologies label Mar 4, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 4, 2019
@dagwieers dagwieers merged commit 12a9492 into ansible:devel Mar 4, 2019
@dagwieers dagwieers added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Mar 4, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aci Cisco ACI community affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dagwieers @ansibot