Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YUM - handle enable of non-existent repo #53286

Merged
merged 11 commits into from
May 15, 2019
Merged

YUM - handle enable of non-existent repo #53286

merged 11 commits into from
May 15, 2019

Conversation

maxamillion
Copy link
Contributor

SUMMARY

Fixes #52582

The YUM CLI gracefully handles the scenario in which an user enables
a repo that doesn't exists, we should as well.

Signed-off-by: Adam Miller admiller@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

yum

@maxamillion maxamillion requested a review from mkrizek March 4, 2019 18:21
@ansibot
Copy link
Contributor

ansibot commented Mar 4, 2019

cc @Akasurde @berenddeschouwer @kustodian @verm666
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 4, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/yum-enable-missing-repo.yaml:0:0: invalid section: bugfix

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 4, 2019
@ansibot ansibot removed needs_triage Needs a first human triage before being processed. ci_verified Changes made in this PR are causing tests to fail. labels Mar 4, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 8, 2019
@maxamillion maxamillion force-pushed the bugfix/52582-yum-enable-missing-repo branch from 30be912 to c25d612 Compare March 8, 2019 17:27
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 8, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Mar 13, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 21, 2019
@maxamillion maxamillion force-pushed the bugfix/52582-yum-enable-missing-repo branch from c25d612 to 98e84b9 Compare April 8, 2019 19:50
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 9, 2019

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:2275:0: undefined-label: undefined label: qradar_test_httapi_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:1516:0: undefined-label: undefined label: qradar_test_httapi_module (if the link has no caption the label must precede a section header)

click here for bot help

maxamillion and others added 11 commits April 22, 2019 16:52
@maxamillion
YUM - handle enable of non-existent repo
ea3ad0f 
Fixes ansible#52582

The YUM CLI gracefully handles the scenario in which an user enables
a repo that doesn't exists, we should as well.

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
switch to unicode str, fix changelog fragment
f32d624 
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
now with a test case!
ee983f2 
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
ensure to_text for comparison
b207b73 
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
handle all calls to enableRepo, switch to failing to model yum cli be…
3763f4e 
…havior

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
if we expect it to fail, should probably ignore_errors
fb7617d 
Signed-off-by: Adam Miller <admiller@redhat.com>
@mkrizek @maxamillion
Update lib/ansible/modules/packaging/os/yum.py
d483c94 
Co-Authored-By: maxamillion <admiller@redhat.com>
@maxamillion
remove file that shouldn't be there, add link to fixed issue
0699fde 
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
handle the differences between yum/dnf backends
0c92a3e 
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
fix yum expectations to mirror cli for one vs many bad repo specifica…
13f2470 
…tions mixed with good ones

Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion
actually fix the logic this time, fix test cases
663a3dc 
Signed-off-by: Adam Miller <admiller@redhat.com>
@maxamillion maxamillion force-pushed the bugfix/52582-yum-enable-missing-repo branch from 862f1d7 to 663a3dc Compare April 23, 2019 04:56
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 23, 2019
@maxamillion
Copy link
Contributor Author

@mattclay I think we're good now, thanks for the catch! Please give it a look when you have a chance.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 1, 2019
@mkrizek
Copy link
Contributor

mkrizek commented May 14, 2019

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. shipit This PR is ready to be merged by Core labels May 14, 2019
@mkrizek
Copy link
Contributor

mkrizek commented May 15, 2019

I restarted the CI manually, succeeded this time, merging.

@mkrizek mkrizek merged commit 666dfdc into ansible:devel May 15, 2019
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@maxamillion @ndclt
YUM - handle enable of non-existent repo (ansible#53286)
7406b49
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category new_plugin This PR includes a new plugin. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yum module failing on missing repository.
4 participants
@maxamillion @ansibot @mkrizek @mattclay