vdo: document versions that have read cache options #53291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "readcache" and "readcachesize" options, which correspond to the same options in the "vdo create" and "vdo modify" commands, have been removed in VDO version 6.2. Signed-off-by: Bryan Gurney <bgurney@redhat.com>
ansibot
added
affects_2.8
acozine
removed
the
needs_triage
|
Thanks for maintaining the Ansible documentation @bgurney-rh! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "readcache" and "readcachesize" options, which correspond to
the same options in the "vdo create" and "vdo modify" commands,
have been removed in VDO version 6.2. Document that the read
cache options are only in VDO 6.1 and older.
SUMMARY
The read cache feature in VDO has been removed in VDO version 6.2. No code needs to be changed; instead, add documentation lines to the "readcache" and "readcachesize" options, stating that they are available in VDO versions 6.1 and older, allowing those versions to continue to use playbooks with those options.
ISSUE TYPE
COMPONENT NAME
vdo
ADDITIONAL INFORMATION
If playbooks for systems with VDO 6.2 and newer do not specify the "readcache" or "readcachesize" options, there should not be any errors. If either of these options are specified for VDO 6.2 and above, there will be an error from the "vdo" command stating "unrecognized arguments: --readCache..." and/or "unrecognized arguments: --readCache..."; these errors should be passed through by ansible, and visible to the user.