docker swarm modules: only run integration tests on VMs #53292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattclay
approved these changes
Mar 4, 2019
ansibot
added
affects_2.8
|
The main downside of this is that currently, only the RHEL7 VM is used (since I don't know how to install docker on RHEL8; see #48842), and so everything's Python 2.7. |
|
shipit |
1 similar comment
|
shipit |
ansibot
added
automerge
|
@mattclay @WojciechowskiPiotr thanks for reviewing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR restricts all docker swarm related tests to proper VM based CI nodes. This hopefully improves stability, as putting the docker daemon in and out of swarm mode (and otherwise poking it) seems to destabilize it if you do it too often. This is dangerous if the whole CI system runs inside docker, so we restrict to proper VMs where the docker daemon is installed inside the VM by the setup_docker role.
Note that I didn't add docker daemon restarts to all affected tests, since that can also lead to further problems...
CC @mattclay
ISSUE TYPE
COMPONENT NAME
docker_config
docker_node_facts
docker_secret
docker_stack
docker_swarm_facts
docker_swarm_service