win reg - Support special chars in path #53305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
nitzmahone
approved these changes
Mar 6, 2019
|
After speaking with @nitzmahone we've agreed that the changes here are too big and are slightly a behavioral change. Because of this, it won't be backported to earlier releases but will be available in Ansible 2.8. The latest commit adds a deprecation warning when |
mgoleary
reviewed
Jul 20, 2019
| "HKCC:" { [Microsoft.Win32.Registry]::CurrentConfig } | ||
| "HKCU:" { [Microsoft.Win32.Registry]::CurrentUser } | ||
| "HKLM:" { [Microsoft.Win32.Registry]::LocalMachine } | ||
| "HKU" { [Microsoft.Win32.Registry]::Users } |
There was a problem hiding this comment.
I believe you're missing the colon after HKU here...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The main part of this module is to support using special characters like
/in a registry path. Previously/would be considered a path separator causing it to create a key within a key. The PR also changeswin_reg_statto work with the registry key's(Default)value. This is returned under the""key if nonameis set but can also be queried directly withname: ''. The property is considered to exist if a value has been set.This first part includes a fix for
win_regeditandwin_reg_statthat is backportable to older branches. A future PR will include a deprecation warning for paths that currently use/as a path separator.Fixes #41791.
ISSUE TYPE
COMPONENT NAME
win_regedit
win_reg_stat