Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make debconf compare apples to apples (booleans) #53331

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 5, 2019

hope to fix #25481

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/debconf

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels Mar 5, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2019
@bcoca bcoca merged commit 949ddb4 into ansible:devel Mar 5, 2019
@bcoca bcoca deleted the debconf_bool_fix branch March 5, 2019 21:04
@chemnic
Copy link

chemnic commented Mar 7, 2019

I think this is causing the following error:

MODULE_STDERR:

Traceback (most recent call last):
  File "<stdin>", line 114, in <module>
  File "<stdin>", line 106, in _ansiballz_main
  File "<stdin>", line 49, in invoke_module
  File "/usr/lib/python3.5/imp.py", line 234, in load_module
    return load_source(name, filename, file)
  File "/usr/lib/python3.5/imp.py", line 170, in load_source
    module = _exec(spec, sys.modules[name])
  File "<frozen importlib._bootstrap>", line 626, in _exec
  File "<frozen importlib._bootstrap_external>", line 665, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/tmp/ansible_debconf_payload_1rgqczcg/__main__.py", line 191, in <module>
  File "/tmp/ansible_debconf_payload_1rgqczcg/__main__.py", line 164, in main
UnboundLocalError: local variable 'existing' referenced before assignment

@bcoca
Copy link
Member Author

bcoca commented Mar 7, 2019

@chemnic i cannot reproduce, please open a new issue with a reproducer

@bcoca
Copy link
Member Author

bcoca commented Mar 7, 2019

nvmd, foudn it .. i should test with 'non boolean'

fix b0ddb88

@chemnic
Copy link

chemnic commented Mar 7, 2019

Yes. Fixed. Thank you.

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debconf misreports changed status for boolean variables
3 participants