Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refresh testing_integration.rst #53338

Merged
merged 8 commits into from
Mar 8, 2019
Merged

docs: refresh testing_integration.rst #53338

merged 8 commits into from
Mar 8, 2019

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Mar 5, 2019

Ensures the examples can be run:

  • fedora25 is not available anymore, use fedora29 instead
  • the posix/ci alias does not exist anymore, use shippable/posix/
    instead
  • explain how to list the target without argcomplete
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

testing_integration.rst

@goneri
docs: refresh testing_integration.rst
09b0133 
Ensures the examples can be run:

- fedora25 is not available anymore, use fedora29 instead
- the posix/ci alias does not exist anymore, use shippable/posix/
  instead
- explain how to list the target without argcomplete
@ansibot
Copy link
Contributor

ansibot commented Mar 5, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 5, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Mar 5, 2019
@sivel sivel requested a review from mattclay March 5, 2019 20:41
mattclay
mattclay requested changes Mar 5, 2019
View reviewed changes
docs/docsite/rst/dev_guide/testing_integration.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/testing_integration.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/testing_integration.rst Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 5, 2019
@mattclay @goneri
Apply suggestions from code review
c0eef12 
Co-Authored-By: goneri <goneri@lebouder.net>
@ansibot
Copy link
Contributor

ansibot commented Mar 6, 2019

The test ansible-test sanity --test docs-build [explain] failed with 24 errors:

docs/docsite/rst/dev_guide/testing_integration.rst:131:0: warning: Title level inconsistent:
docs/docsite/rst/dev_guide/testing_integration.rst:143:0: warning: Title level inconsistent:
docs/docsite/rst/dev_guide/testing_integration.rst:188:0: warning: Title level inconsistent:
docs/docsite/rst/dev_guide/testing_integration.rst:200:0: warning: Title level inconsistent:
docs/docsite/rst/dev_guide/testing_integration.rst:213:0: warning: Title level inconsistent:
docs/docsite/rst/dev_guide/testing_integration.rst:219:0: warning: Title level inconsistent:
docs/docsite/rst/index.rst:0:0: unknown: 
docs/docsite/rst/index.rst:0:0: unknown: 
docs/docsite/rst/index.rst:0:0: unknown: 
docs/docsite/rst/index.rst:0:0: unknown: 
docs/docsite/rst/index.rst:0:0: unknown: 
docs/docsite/rst/index.rst:0:0: unknown: 
docs/docsite/rst/index.rst:0:0: unknown: ----------------
docs/docsite/rst/index.rst:0:0: unknown: ----------------
docs/docsite/rst/index.rst:0:0: unknown: -------------------------
docs/docsite/rst/index.rst:0:0: unknown: --------------------------
docs/docsite/rst/index.rst:0:0: unknown: ---------------------------------
docs/docsite/rst/index.rst:0:0: unknown: -----------------------------------------
docs/docsite/rst/index.rst:0:0: unknown: Container Images
docs/docsite/rst/index.rst:0:0: unknown: Other Definitions required
docs/docsite/rst/index.rst:0:0: unknown: Running Integration Tests
docs/docsite/rst/index.rst:0:0: unknown: Running network integration tests locally
docs/docsite/rst/index.rst:0:0: unknown: Writing network integration tests
docs/docsite/rst/index.rst:0:0: unknown: testing-policies

The test ansible-test sanity --test rstcheck [explain] failed with 1 error:

docs/docsite/rst/dev_guide/testing_integration.rst:131:0: Title level inconsistent:

click here for bot help

@goneri
ansible-test should be in $PATH
6cbd763 
In order to simplify the example, we assume `ansible-runner` is in the $PATH.
This patch explains how to get this done.
@goneri
call ansible-runner from bin/, not test/runner
b50ea55 
Since f3d1f95, `bin/` is now the
new home of `ansible-runner`.
@mattclay @goneri
Update docs/docsite/rst/dev_guide/testing_integration.rst
bf6067b 
Co-Authored-By: goneri <goneri@lebouder.net>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 7, 2019
@acozine
Copy link
Contributor

acozine commented Mar 8, 2019

Thanks @goneri for updating the instructions on running the tests. It's great to get a fresh set of eyes (and a full test) on that page!

@acozine acozine merged commit 6421e89 into ansible:devel Mar 8, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@goneri @ansibot @acozine @mattclay @bcoca