Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add '_facts' rule to module checklist #53359

Merged
merged 2 commits into from
Mar 6, 2019
Merged

add '_facts' rule to module checklist #53359

merged 2 commits into from
Mar 6, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 5, 2019

decided in public irc meeting

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs

@ansibot
Copy link
Contributor

ansibot commented Mar 5, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 5, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 6, 2019
@samccann @bcoca
Update docs/docsite/rst/dev_guide/developing_modules_checklist.rst
b7f008c 
Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
@samccann samccann merged commit c0a4cf2 into ansible:devel Mar 6, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoca @ansibot @samccann