Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudscale_server: fix missing param use_private_network #53381

Merged
merged 3 commits into from
Mar 6, 2019
Merged

cloudscale_server: fix missing param use_private_network #53381

merged 3 commits into from
Mar 6, 2019

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Mar 6, 2019

SUMMARY

in the refactoring in #52683 the param use_private_network was left out. This fixes it. adding tests for it. No need for backport.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudscale_server

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 6, 2019

cc @gaudenz
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Mar 6, 2019
@gaudenz
Copy link
Contributor

gaudenz commented Mar 6, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 6, 2019
@resmo resmo merged commit 4ac3172 into ansible:devel Mar 6, 2019
@resmo resmo deleted the fix/cloudscale_server_missing_param branch March 6, 2019 15:22
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@resmo @ansibot @gaudenz