Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change handle_httperror in httpapi plugins #53391

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Change handle_httperror in httpapi plugins #53391

merged 2 commits into from
Mar 6, 2019

Conversation

Qalthos
Copy link
Contributor

@Qalthos Qalthos commented Mar 6, 2019

SUMMARY

The original implementation is somewhat backwards, and does not account for HTTPErrors not actually being fatal.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

httpapi

@ansibot
Copy link
Contributor

ansibot commented Mar 6, 2019

cc @NilashishC @annikulin @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels Mar 6, 2019
@Qalthos Qalthos removed the needs_triage Needs a first human triage before being processed. label Mar 6, 2019
@Qalthos Qalthos merged commit 3fe2013 into ansible:devel Mar 6, 2019
@Qalthos Qalthos deleted the httpapi branch March 6, 2019 17:14
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Qalthos @ansibot