Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower_credential: Add parameter vault_id #53400

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Mar 6, 2019

SUMMARY

vault_id allows user to specify vault identifier as per Tower UI.

Fixes: #45644

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/web_infrastructure/ansible_tower/tower_credential.py

vault_id allows user to specify vault identifier as per Tower UI.

Fixes: ansible#45644

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Mar 6, 2019

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. tower Tower community web_infrastructure Web-infrastructure category labels Mar 6, 2019
@AlanCoding
Copy link
Member

shipit

Ping @ryanpetrello, this isn't the most ideal solution that we wanted. However, this is a significant enough of a pain point that I would prefer to give up and let users put it in the top-level keys. Plus, there's no implementation of an inputs field anywhere in sight.

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 6, 2019
@ansibot ansibot merged commit 831f068 into ansible:devel Mar 6, 2019
@Akasurde Akasurde deleted the i45644 branch March 7, 2019 02:26
@Akasurde
Copy link
Member Author

Akasurde commented Mar 7, 2019

@AlanCoding Thanks for the review.

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. tower Tower community web_infrastructure Web-infrastructure category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault identifier is not exposed in tower_credential
3 participants