-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleaning up azure_rm_deployment samples & return value doc #53436
Conversation
CI failure in integration tests: https://app.shippable.com/github/ansible/ansible/runs/112336/87/tests |
instances: | ||
description: Provides the public IP addresses for each VM instance. | ||
type: list | ||
returned: always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return always? what if my arm template doesn't contain VM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, field is always returned, it may just be empty []
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's confusing, such as public ip marked as returned always also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the lists are always returned, just may be empty,
maybe we could have:
returned: always but list may be empty
or just
returned when applicable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think "instances" return value should be made obsolete.
it works only with vms.
if somebody uses ARM templates to deploy anything else than VM it's pretty much useless.
we could think of more universal approach.
Usually outputs should be sufficient to use created resources. For instance for Windows VM, outputs look like:
"outputs": {
"hostname": {
"type": "String",
"value": "zimsdplxxxx.eastus2.cloudapp.azure.com"
}
}
So it has sufficient information to use the VM.
Outputs are designed by ARM template authors so it's up to them what's important for the user.
34f0172
to
9dd9690
Compare
SUMMARY
Just some naming conventions, etc.
Added name parameter in every sample
Removed some unnecessary things like subscription_id
Fixed & extended return value documentation
ISSUE TYPE
COMPONENT NAME
azure_rm_deployment
ADDITIONAL INFORMATION