Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iptables: Add support for gateway parameter #53465

Merged
merged 1 commit into from
Mar 13, 2019
Merged

iptables: Add support for gateway parameter #53465

merged 1 commit into from
Mar 13, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Mar 7, 2019 •
edited

SUMMARY

When user specifies the JUMP value to 'tee', gateway is required.
This fix adds new parameter 'gateway' to support this functionality.

Fixes: #53170

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

changelogs/fragments/53170-iptables-support_gateway.yml
lib/ansible/modules/system/iptables.py
test/units/modules/system/test_iptables.py

@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2019

cc @LinusU @sebastiendarocha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 7, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 10, 2019
@Akasurde Akasurde mentioned this pull request Mar 10, 2019
Closed
goneri
goneri suggested changes Mar 11, 2019
View reviewed changes
lib/ansible/modules/system/iptables.py Outdated Show resolved Hide resolved
lib/ansible/module_utils/basic.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 11, 2019
@Akasurde
iptables: Add support for gateway parameter
34c44f9 
When user specifies the JUMP value to 'tee', gateway is required.
This fix adds new parameter 'gateway' to support this functionality.

Fixes: ansible#53170

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Mar 12, 2019
@goneri
Copy link
Contributor

goneri commented Mar 13, 2019

shipit

@Akasurde Akasurde merged commit f0ef4da into ansible:devel Mar 13, 2019
@Akasurde Akasurde deleted the i53170 branch March 13, 2019 12:17
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goneri goneri goneri requested changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iptables missing --gateway flag for -j TEE
3 participants
@Akasurde @ansibot @goneri