Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to work around spurious test failures. #53472

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Trying to work around spurious test failures. #53472

merged 1 commit into from
Mar 7, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Sometimes, one of the docker_image tests fails:
https://app.shippable.com/github/ansible/ansible/runs/112356/64/tests
https://app.shippable.com/github/ansible/ansible/runs/112399/71/tests

This PR tries to "fix" this by allowing this situation to happen, and checking an additional condition in case it does.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_image

@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @danihodovic @dariko @jwitko @kassiansun @softzilla @tbouvet
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Mar 7, 2019
@felixfontein
Copy link
Contributor Author

Ugly, but does the job. Merging for now.

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 7, 2019
@ansibot ansibot merged commit e4f2e15 into ansible:devel Mar 7, 2019
@felixfontein felixfontein deleted the docker_image-fix-tests branch March 7, 2019 19:40
felixfontein added a commit to felixfontein/ansible that referenced this pull request Mar 7, 2019
@felixfontein
Trying to work around spurious test failures. (ansible#53472)
f79b17b 
(cherry picked from commit e4f2e15)
@felixfontein felixfontein mentioned this pull request Mar 7, 2019
Merged
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2019
abadger pushed a commit that referenced this pull request Mar 11, 2019
@felixfontein @abadger
Trying to work around spurious test failures. (#53472)
9135dbd 
(cherry picked from commit e4f2e15)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud docker shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @ansibot @sivel