docker_swarm_service: Documentation fixes #53479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
|
This PR is pretty hard to read. Can you split it up into two PRs:
That would make reviewing the PRs much easier. |
This reverts commit 51dabcc.
|
@felixfontein good idea. I'll create a PR with the reordering once this is merged. |
felixfontein
reviewed
Mar 7, 2019
| @@ -461,7 +465,6 @@ | |||
| mode: | |||
| description: | |||
| - What publish mode to use. | |||
| - Service will be removed and recreated when changed. | |||
There was a problem hiding this comment.
Is this no longer true for publish mode?
There was a problem hiding this comment.
This was never true. In #52634 I added that string to the wrong mode-option.
There was a problem hiding this comment.
It's supposed to be documented on the actual mode-option and not publish.mode.
ansibot
removed
the
needs_triage
ansibot
added
shipit
|
@felixfontein thank you for reviewing. @sivel thank you for merging. |
|
@hannseman and thanks for the PR! :) Looks like #53482 needs a rebase now... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a number of issues:
modechoices is now validated and documented. Documentation about recreation of service is now correctly under this option and notpublish.modesecretsandusersto module return valueBTW @felixfontein I love these new fast tests!
ISSUE TYPE
COMPONENT NAME
docker_swarm_service