Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_swarm_service: Add read_only option #53482

Merged
merged 4 commits into from
Mar 8, 2019
Merged

docker_swarm_service: Add read_only option #53482

merged 4 commits into from
Mar 8, 2019

Conversation

hannseman
Copy link
Contributor

SUMMARY

Add read_only option.

https://docs.docker.com/engine/reference/commandline/service_create/#options

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

docker_swarm_service

@ansibot
Copy link
Contributor

ansibot commented Mar 7, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @danihodovic @dariko @felixfontein @jwitko @kassiansun @tbouvet
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Mar 7, 2019
felixfontein
felixfontein approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah wait.

@felixfontein
Copy link
Contributor

Just saw something :) read_only needs a version_added: 2.8.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 7, 2019
@hannseman
Copy link
Contributor Author

Always miss that one! Don't get that error when running the sanity-checks locally with test/runner/ansible-test sanity --python=2.7 docker_swarm_service.

@felixfontein
Copy link
Contributor

Yep, that part of the sanity checks doesn't seem to work locally...

BTW, have you seen the test failures?

felixfontein
felixfontein approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 7, 2019
@jwitko
Copy link
Contributor

jwitko commented Mar 8, 2019

needs_rebase

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Mar 8, 2019
@felixfontein felixfontein mentioned this pull request Mar 8, 2019
Merged
@hannseman hannseman force-pushed the docker_swarm_service-read_only branch from 042591f to 903f454 Compare March 8, 2019 07:49
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 8, 2019
@gundalow
Copy link
Contributor

gundalow commented Mar 8, 2019

rebuild_merge

Thanks all!

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 8, 2019
@ansibot ansibot merged commit f5faf82 into ansible:devel Mar 8, 2019
@felixfontein
Copy link
Contributor

Also thanks from me! :)

@hannseman hannseman deleted the docker_swarm_service-read_only branch March 11, 2019 19:23
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud docker feature This issue/PR relates to a feature request. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hannseman @ansibot @felixfontein @jwitko @gundalow