[2.7] docker_swarm: removing nodes requires docker >= 2.4.0 #53592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calls client.inspect_node(). (ansible#53565) For the same reason, docker_node requires docker >= 2.4.0. (cherry picked from commit c75da35)
…tection work this way.
ansibot
added
affects_2.7
|
shipit |
ansibot
added
shipit
|
Merged for the 2.7.9 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport of #53565 to stable-2.7. This is an update to the already merged backport #53272, which ensures that one feature which requires docker-py >= 2.4.0 (because of a docker-py bug) will fail with a proper error (instead of crashing because of docker-py).
(This is unfortunately one of the features which can't be tested in CI, since it needs a swarm cluster with at least two nodes...)
ISSUE TYPE
COMPONENT NAME
docker_swarm