nxos_linkagg: group type mismatch causes idempotency failure
#53653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `group` values need to be cast; e.g.
```
want = {'group': '20'}
have = {'group': 20}
```
* Found with N7K `sanity` test
ansibot
added
affects_2.8
trishnaguha
reviewed
Mar 12, 2019
| @@ -135,7 +135,7 @@ | |||
|
|
|||
| def search_obj_in_list(group, lst): | |||
| for o in lst: | |||
| if o['group'] == group: | |||
| if str(o['group']) == str(group): | |||
There was a problem hiding this comment.
Looks like this is because of https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_linkagg.py#L267. We did it because some of the platforms/versions return group as str.
Instead of masking it here, I would rather change the type of group param to str https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_linkagg.py#L375 and make sure the that the group info we fetch from the device is string format obj['group'] = str(group) https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/nxos/nxos_linkagg.py#L337
There was a problem hiding this comment.
Agreed, I'll change and retest.
trishnaguha
removed
the
needs_triage
trishnaguha
approved these changes
Mar 13, 2019
abadger
pushed a commit
that referenced
this pull request
Apr 4, 2019
* nxos_linkagg: `group` type mismatch causes idempotency failure
* `group` values need to be cast; e.g.
```
want = {'group': '20'}
have = {'group': 20}
```
* Found with N7K `sanity` test
* nxos_linkagg: change group param type to str
(cherry picked from commit 66fe6bf)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
groupvalues need to be cast; e.g.sanitytestISSUE TYPE
COMPONENT NAME
nxos_linkagg