Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP team needs access to the GCP Document Fragment #53659

Merged
merged 1 commit into from
Mar 13, 2019
Merged

GCP team needs access to the GCP Document Fragment #53659

merged 1 commit into from
Mar 13, 2019

Conversation

rambleraptor
Copy link
Contributor

SUMMARY

GCP has a document fragment that's shared across modules. The team doesn't have merge access to this file. This is blocking #53490

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/doc_fragments/gcp.py
.github/BOTMETA.yml

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 botmeta This PR modifies the BOTMETA.yml and this requires special attention! bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 11, 2019
@rambleraptor
Copy link
Contributor Author

@gundalow could you take a look?

@gundalow gundalow merged commit f658a74 into ansible:devel Mar 13, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 13, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 botmeta This PR modifies the BOTMETA.yml and this requires special attention! bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rambleraptor @gundalow @sivel @ansibot