ACME: add support for IP identifiers

[felixfontein]

SUMMARY

According to https://tools.ietf.org/html/draft-ietf-acme-ip-05. First interoperability tests with letsencrypt/pebble#221 are looking good. This is essentially the acme_certificate part of #53228.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

acme_certificate

[ansibot]

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @mgruener @puiterwijk @resmo
click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 3 errors:

test/units/module_utils/test_acme.py:207:44: trailing-whitespace Trailing whitespace
test/units/module_utils/test_acme.py:261:16: trailing-whitespace Trailing whitespace
test/units/module_utils/test_acme.py:304:44: trailing-whitespace Trailing whitespace

click here for bot help

[felixfontein]

@mattclay I want to preserve the trailing whitespaces in the OpenSSL outputs which are part of the unit tests. I've tried to skip the pep8 tests for this unit tests (df7e282d87f5cdf0d01cbe65492e2412ea7ca470), but this apparently didn't work. Do you know what went wrong? I could also do this by adding """ + r""" at the end of the line. Is this maybe a better approach (because it also will stop random editor settings to cut them off)?

[mattclay]

@felixfontein Definitely don't skip the pep8 checks. For large static content like that, I'd put it in a separate file and load it during the test instead of trying to embed it in the code.

[felixfontein]

@mattclay I've rearranged it as follows: a27afa7 Is the folder structure ok? (I.e. will the CI system find the tests if lib/ansible/module_utils/acme.py is changed?)

[mattclay]

@felixfontein Yes, the folder structure is correct. The unit tests to run will be determined based on import analysis, so there's no issue there. It's actually more important that the fixtures are in the correct location so changes to them will run the tests. Those are OK as well.

You can check with the following commands:

ansible-test units --changed-path test/units/module_utils/acme/fixtures/cert_1.pem -e
ansible-test units --changed-path lib/ansible/module_utils/acme.py -e

Those will show what tests will run based on files changing.

[felixfontein]

@mattclay great, thanks a lot!

[felixfontein]

ready_for_review

[resmo]

don't see anything to block this from getting in. Good job.

shipit

[felixfontein]

@resmo thanks for reviewing and merging!
@mattclay thanks for helping with the tests!