Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme_challenge_cert_helper: add support for IP identifiers #53661

Merged
merged 3 commits into from
Mar 13, 2019
Merged

acme_challenge_cert_helper: add support for IP identifiers #53661

merged 3 commits into from
Mar 13, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Adds support for IP identifiers to acme_challenge_cert_helper. Uses the extended TLS-ALPN-01 challenge data returned by #53660.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

acme_challenge_cert_helper

@felixfontein felixfontein force-pushed the acme-ip-identifiers-tls-alpn-01 branch from a45c3df to e8089f7 Compare March 11, 2019 21:06
@felixfontein felixfontein mentioned this pull request Mar 11, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Mar 11, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 11, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2019
resmo
resmo approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 12, 2019
@resmo resmo merged commit 028facd into ansible:devel Mar 13, 2019
@felixfontein
Copy link
Contributor Author

@resmo thanks for reviewing and merging!

@felixfontein felixfontein deleted the acme-ip-identifiers-tls-alpn-01 branch March 13, 2019 09:25
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 crypto Crypto community (ACME, openssl, letsencrypt) feature This issue/PR relates to a feature request. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @ansibot @resmo