Fix checksum file parsing in get_url #53685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is likely beneficial to view this PR with whitespace changes hidden: https://github.com/ansible/ansible/pull/53685/files?diff=unified&w=1 |
ansibot
added
affects_2.8
samdoran
suggested changes
Mar 12, 2019
Co-Authored-By: sivel <matt@sivel.net>
samdoran
approved these changes
Mar 12, 2019
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Mar 12, 2019
* Fix checksum file parsing. Fixes ansible#48790 * guard invalid int conversion Co-Authored-By: sivel <matt@sivel.net> * Remove extra newline. (cherry picked from commit 77217fd) Co-authored-by: Matt Martz <matt@sivel.net>
sivel
removed
the
needs_triage
abadger
pushed a commit
that referenced
this pull request
Mar 18, 2019
* [stable-2.7] Fix checksum file parsing in get_url (#53685) * Fix checksum file parsing. Fixes #48790 * guard invalid int conversion Co-Authored-By: sivel <matt@sivel.net> * Remove extra newline. (cherry picked from commit 77217fd) Co-authored-by: Matt Martz <matt@sivel.net> * Remove use of undefined variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix checksum file parsing in get_url. Fixes #48790
Due to over zealous exception catching, we were obscuring the real error. The real error was the result of assuming that every line in a checksum file could be split into exactly 2 parts.
This PR:
checksum_mapinstead of re-using a variablelinesthat was converted from a list to a dictISSUE TYPE
COMPONENT NAME
lib/ansible/modules/net_tools/basic/get_url.py
ADDITIONAL INFORMATION