Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirt_pvc: add 'wait' support #53692

Merged
merged 1 commit into from
Mar 13, 2019
Merged

kubevirt_pvc: add 'wait' support #53692

merged 1 commit into from
Mar 13, 2019

Conversation

mmazur
Copy link
Contributor

@mmazur mmazur commented Mar 12, 2019

SUMMARY

Adds blocking (wait) for PVC creation.

ISSUE TYPE
  • Feature Pull Reques
COMPONENT NAME

module/kubevirt_pvc

@ansibot
Copy link
Contributor

ansibot commented Mar 12, 2019

cc @kubevirt @machacekondra @pkliczewski
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 12, 2019
@mmazur mmazur force-pushed the kubevirt_pvc_wait_modern branch 2 times, most recently from 56628cd to 9a8fa6a Compare March 13, 2019 10:17
@mmazur mmazur changed the title [WIP] kubevirt_pvc: add 'wait' support kubevirt_pvc: add 'wait' support Mar 13, 2019
@mmazur mmazur mentioned this pull request Mar 13, 2019
Merged
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Mar 13, 2019
@mmazur
Copy link
Contributor Author

mmazur commented Mar 13, 2019

Ok, all done and tested, please ack.

@pkliczewski
Copy link

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 13, 2019
@ansibot ansibot merged commit 4cab425 into ansible:devel Mar 13, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra left review comments

@pkliczewski pkliczewski pkliczewski approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmazur @ansibot @pkliczewski @machacekondra