Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_psexec: make the tests more stable #53716

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Add a retry the test task that was unsable. Sometimes in CI when this task is run there is no output returned by PsExec. This PR just retries the task at least 3 times before it considers it a failure.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_psexec

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2019

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Mar 13, 2019
@jborean93
Copy link
Contributor Author

You can see the unstable nature of this test on the 2012 host https://app.shippable.com/github/ansible/ansible/runs/113515/25/console. The win_psexec : Run whoami as SYSTEM task failed on the first run but succeeded on the next one.

@jborean93 jborean93 merged commit 33939f7 into ansible:devel Mar 13, 2019
@jborean93 jborean93 deleted the test-win_psexec branch March 13, 2019 01:23
jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 13, 2019
jborean93 added a commit to jborean93/ansible that referenced this pull request Mar 13, 2019
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.6 #53719
stable-2.7 #53720

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Mar 13, 2019
abadger pushed a commit that referenced this pull request Mar 18, 2019
abadger pushed a commit that referenced this pull request Mar 18, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants