Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushover: Adds support for optional 'title' #53726

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Conversation

desimaniac
Copy link
Contributor

SUMMARY

Adds support for optional 'title' to Pushover module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pushover

ADDITIONAL INFORMATION
ok: [localhost] => {
    "changed": false,
    "invocation": {
        "module_args": {
            "app_token": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "msg": "System has exploded in flames, It is now time to panic!",
            "pri": "0",
            "title": "Alert!",
            "user_key": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "msg": "message sent successfully: {\"status\":1,\"request\":\"REDACTED\"}"

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2019

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. notification Notification category support:community This issue/PR relates to code supported by the Ansible community. labels Mar 13, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/notification/pushover.py:91:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/notification/pushover.py:95:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

lib/ansible/modules/notification/pushover.py:42:20: W291 trailing whitespace
lib/ansible/modules/notification/pushover.py:57:1: W293 blank line contains whitespace
lib/ansible/modules/notification/pushover.py:91:1: W293 blank line contains whitespace
lib/ansible/modules/notification/pushover.py:93:11: E111 indentation is not a multiple of four
lib/ansible/modules/notification/pushover.py:95:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/notification/pushover.py:0:0: E309 version_added for new option (title) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 13, 2019
** SUMMARY **
Adds support for optional 'title'.

** ISSUE TYPE **
Feature Pull Request

** COMPONENT NAME **
pushover
@desimaniac
Copy link
Contributor Author

bot_status

@desimaniac
Copy link
Contributor Author

ready_for_review

@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2019

Components

lib/ansible/modules/notification/pushover.py
support: community
maintainers: weaselkeeper

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 13, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 21, 2019
@desimaniac desimaniac closed this Mar 25, 2019
@desimaniac desimaniac reopened this Mar 25, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 25, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 2, 2019
@resmo
Copy link
Contributor

resmo commented Apr 10, 2019

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core automerge This PR was automatically merged by ansibot. and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 10, 2019
@ansibot ansibot merged commit b41c6fc into ansible:devel Apr 10, 2019
@desimaniac desimaniac deleted the patch-1 branch April 11, 2019 02:42
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. notification Notification category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants