Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly update tags when os_stack invokes update_stack #53757

Merged
merged 4 commits into from
Apr 4, 2019
Merged

Correctly update tags when os_stack invokes update_stack #53757

merged 4 commits into from
Apr 4, 2019

Conversation

brtkwr
Copy link
Contributor

@brtkwr brtkwr commented Mar 13, 2019 •
edited

Correctly update tags when os_stack invokes update_stack

SUMMARY

If a user invokes os_stack on a cluster that already exists and tag is supplied, it is not applied correctly. This patch addresses this issue by supplying tag to update_stack invocation.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_stack

ADDITIONAL INFORMATION

@brtkwr brtkwr changed the title Fix removal of tag when os_stack invokes update if a stack already ex… Correctly update tags when os_stack invokes update_stack Mar 13, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 13, 2019

cc @Shrews @cloudnull @dagnello @emonty @evrardjp @juliakreger @matbu @mnaser @odyssey4me @rcarrillocruz @steveb
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. openstack small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Mar 13, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Mar 13, 2019

Build succeeded (third-party-check pipeline).

@opendev-zuul
Copy link

opendev-zuul bot commented Mar 13, 2019

Build succeeded (third-party-check pipeline).

@brtkwr
Copy link
Contributor Author

brtkwr commented Mar 14, 2019

Depends on: https://review.openstack.org/#/c/643195/3 and backports

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 22, 2019
@brtkwr brtkwr mentioned this pull request Mar 27, 2019
Merged
openstack-gerrit pushed a commit to openstack/openstack that referenced this pull request Mar 28, 2019
@openstack-gerrit
Update git submodules
5ce3020 
* Update openstacksdk from branch 'master'
  - Merge "Do not disregard tags when updating stacks"
  - Do not disregard tags when updating stacks
    
    At present, if tags are supplied to the update_stack function, it is
    completely disregarded while create_stack in fact allows it. This leads
    the Ansible module os_stack to also not be able to propagate tags
    properly. This is suboptimal therefore this patch aims to sort the issue
    out.
    
    Resolves: ansible/ansible#53757
    
    Change-Id: I59e7c47b8c01f96ec561b8bd153804bac5f21800
    Story: 2005226
    Task: 30008
openstack-gerrit pushed a commit to openstack/openstacksdk that referenced this pull request Mar 28, 2019
@brtkwr @priteau
Do not disregard tags when updating stacks
a0ec8ef 
At present, if tags are supplied to the update_stack function, it is
completely disregarded while create_stack in fact allows it. This leads
the Ansible module os_stack to also not be able to propagate tags
properly. This is suboptimal therefore this patch aims to sort the issue
out.

Resolves: ansible/ansible#53757

Change-Id: I59e7c47b8c01f96ec561b8bd153804bac5f21800
Story: 2005226
Task: 30008
@mnaser
Copy link
Contributor

mnaser commented Mar 29, 2019

I've reached out to @emonty and got the following, so this is probably the best avenue:

http://eavesdrop.openstack.org/irclogs/%23openstack-sdks/%23openstack-sdks.2019-03-28.log.html#t2019-03-28T15:49:08

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 29, 2019
@emonty
Copy link
Contributor

emonty commented Mar 29, 2019

shipit

@ansibot ansibot removed small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 29, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 29, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_stack.py:258:90: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/cloud/openstack/os_stack.py:257:33: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/openstack/os_stack.py:258:33: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/openstack/os_stack.py:258:91: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 29, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 29, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Mar 29, 2019

Build succeeded (third-party-check pipeline).

@mnaser
Copy link
Contributor

mnaser commented Mar 29, 2019

shipit

@emonty
Copy link
Contributor

emonty commented Apr 4, 2019

shipit

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 4, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Apr 4, 2019

Build succeeded (third-party-check pipeline).

@ansibot
Copy link
Contributor

ansibot commented Apr 4, 2019

cc @gtema
click here for bot help

@brtkwr
Copy link
Contributor Author

brtkwr commented Apr 4, 2019

Hmm I don't understand why its failing.

@gtema
Copy link
Contributor

gtema commented Apr 4, 2019

shipit

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. labels Apr 4, 2019
@ansibot ansibot merged commit c6ed5b3 into ansible:devel Apr 4, 2019
@brtkwr brtkwr deleted the patch-1 branch April 4, 2019 13:55
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gtema gtema gtema approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. openstack shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brtkwr @ansibot @mnaser @emonty @gtema