Allow customization of hostname source for azure_rm inventory plugin to enable awx adoption of plugin

[kdelee]

SUMMARY

Currently, the appending of a hashed set of characters to the end of host names brought in by the azure_rm inventory plugin is considered a breaking change by awx developers because it would break the use of host limits on any playbooks (they would no longer match).

This happens here:

ansible/lib/ansible/plugins/inventory/azure_rm.py

Lines 492 to 493 in b54fddb

	# Azure often doesn't provide a globally-unique filename, so use resource name + a chunk of ID hash
	self.default_inventory_hostname = '{0}_{1}'.format(vm_model['name'], hashlib.sha1(to_bytes(vm_model['id'])).hexdigest()[0:4])

It is mentioned in the source code and implemented in other plugins to enable customization of the source of the hostname:

ansible/lib/ansible/plugins/inventory/azure_rm.py

Lines 355 to 356 in b54fddb

	# FUTURE: configurable hostname sources
	return host.default_inventory_hostname

e.g. we would like a feature that let us pass in a hostvar we would like to use as the host name.

ISSUE TYPE

• Bug Report
• Feature Idea

COMPONENT NAME

azure_rm inventory plugin

ANSIBLE VERSION

devel

@AlanCoding this is the issue we discussed that we need to enable azure plugin

[ansibot]

Files identified in the description:

• lib/ansible/plugins/inventory/azure_rm.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[AlanCoding]

Proposed fix at #54060

This needs an additional patch as well.

[AlanCoding]

Link second patch needed #54074

[AlanCoding]

Link alternative for second patch #54099

This means that, in order to resolve this, #54060 is needed in conjunction with either #54099 OR #54074

[AlanCoding]

Update - #54060 and #54099 are needed

[AlanCoding]

The other one was merged, so only #54060 is needed now.

[AlanCoding]

This is resolved

issue can be closed

[abadger]

#54060 merged, closing this issue