Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

na_ontap_gather_facts: Add gather subset system_node_info #54161

Merged
merged 2 commits into from
Apr 11, 2019
Merged

na_ontap_gather_facts: Add gather subset system_node_info #54161

merged 2 commits into from
Apr 11, 2019

Conversation

Matthias-Beck
Copy link
Contributor

@Matthias-Beck Matthias-Beck commented Mar 21, 2019 •
edited

SUMMARY

Added the subset system_node_info to get information about the node like model, serial etc.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

na_ontap_gather_facts

ADDITIONAL INFORMATION

Added to geth further information about the hardware.

"key": "system_node_info",
            "value": {
                "<node-name>": {
                    "cpu_busytime": "211044",
                    "cpu_firmware_release": "11.2.1",
                    "env_failed_fan_count": "0",
                    "env_failed_fan_message": "There are no failed fans.",
                    "env_failed_power_supply_count": "0",
                    "env_failed_power_supply_message": "There are no failed power supplies.",
                    "env_over_temperature": "false",
                    "is_all_flash_optimized": "false",
                    "is_cloud_optimized": "false",
                    "is_diff_svcs": "false",
                    "is_epsilon_node": "false",
                    "is_node_cluster_eligible": "true",
                    "is_node_healthy": "true",
                    "maximum_aggregate_size": "439804651110400",
                    "maximum_number_of_volumes": "1000",
                    "maximum_volume_size": "109951162777600",
                    "node": "<node_name>",
                    "node_location": "<location>",
                    "node_model": "FAS2750",
                    "node_nvram_id": "<nvramid>",
                    "node_owner": null,
                    "node_serial_number": "<serial>",
                    "node_storage_configuration": "multi_path_ha",
                    "node_system_id": "<systemid>",
                    "node_uptime": "5676782",
                    "node_uuid": "<uuid>",
                    "node_vendor": "NetApp",
                    "nvram_battery_status": "battery_ok",
                    "product_version": "NetApp Release 9.4P5: Thu Dec 13 14:13:50 UTC 2018"
                },....

@ansibot
Copy link
Contributor

ansibot commented Mar 21, 2019

cc @amit0701 @carchi8py @dprts @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 committer_review In order to be merged, this PR must follow the certified review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp new_contributor This PR is the first contribution by a new community member. storage support:certified This issue/PR relates to certified code. labels Mar 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 21, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_gather_facts.py:271:12: E131 continuation line unaligned for hanging indent

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed committer_review In order to be merged, this PR must follow the certified review workflow. labels Mar 21, 2019
@ansibot ansibot added committer_review In order to be merged, this PR must follow the certified review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 21, 2019
@gundalow gundalow changed the title Add gather subset system_node_info na_ontap_gather_facts: Add gather subset system_node_info Mar 21, 2019
lonico
lonico approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

carchi8py
carchi8py approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@carchi8py carchi8py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 21, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 30, 2019
@thedoubl3j
Copy link
Member

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 11, 2019
@thedoubl3j thedoubl3j merged commit 1a7fed9 into ansible:devel Apr 11, 2019
@Matthias-Beck Matthias-Beck deleted the patch-1 branch April 11, 2019 17:50
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carchi8py carchi8py carchi8py approved these changes

@lonico lonico lonico approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp new_contributor This PR is the first contribution by a new community member. shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Matthias-Beck @ansibot @thedoubl3j @carchi8py @lonico