Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_publickey: fix handling of OpenSSH private keys with passphrase #54192

Merged
merged 3 commits into from
Mar 22, 2019
Merged

openssl_publickey: fix handling of OpenSSH private keys with passphrase #54192

merged 3 commits into from
Mar 22, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #54190.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_privatekey

@felixfontein felixfontein changed the title openssl_publickey: fix hanlding of OpenSSH private keys with passphrase openssl_publickey: fix handling of OpenSSH private keys with passphrase Mar 21, 2019
@felixfontein felixfontein mentioned this pull request Mar 21, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Mar 21, 2019

cc @MarkusTeufelberger @Shaps @Spredzy @Xyon @puiterwijk @resmo
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 21, 2019
@Shaps
Copy link
Contributor

Shaps commented Mar 21, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Mar 21, 2019
@felixfontein
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Mar 22, 2019

Components

changelogs/fragments/54192-openssl_publickey-openssh-passphrase.yml
support: community
maintainers:

lib/ansible/modules/crypto/openssl_publickey.py
support: community
maintainers: MarkusTeufelberger Shaps Spredzy Xyon felixfontein puiterwijk resmo

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 2
shipit_actors (maintainers or core team members): Shaps felixfontein
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@felixfontein
Copy link
Contributor Author

shipit

1 similar comment
@Akasurde
Copy link
Member

shipit

@Akasurde Akasurde merged commit 1a94cf1 into ansible:devel Mar 22, 2019
@felixfontein felixfontein deleted the openssl_publickey-fix-openssh branch March 22, 2019 17:27
@felixfontein
Copy link
Contributor Author

@Shaps thanks for reviewing!
@Akasurde thanks for merging!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Mar 22, 2019
@felixfontein
openssl_publickey: fix handling of OpenSSH private keys with passphra…
a18eb31 
…se (ansible#54192)

* Cleanup.
* Make sure that OpenSSH passphrases are handled correctly.
* Add changelog.

(cherry picked from commit 1a94cf1)
felixfontein added a commit to felixfontein/ansible that referenced this pull request Mar 22, 2019
@felixfontein
openssl_publickey: fix handling of OpenSSH private keys with passphra…
74d4f8f 
…se (ansible#54192)

* Cleanup.
* Make sure that OpenSSH passphrases are handled correctly.
* Add changelog.

(cherry picked from commit 1a94cf1)
This was referenced Mar 22, 2019
Merged
Merged
abadger pushed a commit that referenced this pull request Mar 22, 2019
@felixfontein @abadger
openssl_publickey: fix handling of OpenSSH private keys with passphra…
3d5bf87 
…se (#54192)

* Cleanup.
* Make sure that OpenSSH passphrases are handled correctly.
* Add changelog.

(cherry picked from commit 1a94cf1)
abadger pushed a commit that referenced this pull request Mar 22, 2019
@felixfontein @abadger
openssl_publickey: fix handling of OpenSSH private keys with passphra…
e1c53bd 
…se (#54192)

* Cleanup.
* Make sure that OpenSSH passphrases are handled correctly.
* Add changelog.

(cherry picked from commit 1a94cf1)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl_publickey is broken in python3
4 participants
@felixfontein @ansibot @Shaps @Akasurde