Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify kubevirt_vm crud/wait logic #54404

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Modify kubevirt_vm crud/wait logic #54404

merged 1 commit into from
Apr 4, 2019

Conversation

mmazur
Copy link
Contributor

@mmazur mmazur commented Mar 26, 2019

SUMMARY
  1. Adds proper wait support for VM stops and starts
  2. Detect Bug: kubevirt modules return an admission webhook error instead of the proper 404: vm not found kubevirt/ansible-kubevirt-modules#177 and return a sane error
  3. Switch to openshift-restclient 0.9.x style wait code
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubevirt/kubevirt_vm

@ansibot
Copy link
Contributor

ansibot commented Mar 26, 2019

cc @kubevirt @machacekondra @pkliczewski
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Mar 26, 2019
@mmazur
Copy link
Contributor Author

mmazur commented Mar 26, 2019

@machacekondra @pkliczewski – our e2e testing works ok: https://travis-ci.org/kubevirt/ansible-kubevirt-modules/jobs/511551711

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 26, 2019
@mmazur mmazur force-pushed the kubevirt_vm_new_logic branch 2 times, most recently from 0311893 to 99688c5 Compare March 27, 2019 09:46
@ansibot ansibot removed the owner_pr This PR is made by the module's maintainer. label Mar 27, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 27, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 27, 2019
@mmazur mmazur mentioned this pull request Mar 27, 2019
Closed
@mmazur
Copy link
Contributor Author

mmazur commented Mar 27, 2019

And done. As far as I can tell everything is working correctly. I'll add a PR extending our travis playbooks to make sure all of this always gets solidly tested. Other than that, once the ansible CI finishes, you can shipit.

machacekondra
machacekondra reviewed Apr 3, 2019
View reviewed changes
Copy link
Contributor

@machacekondra machacekondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 3, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed shipit This PR is ready to be merged by Core labels Apr 3, 2019
@mmazur
Copy link
Contributor Author

mmazur commented Apr 3, 2019

Right, turns out there were still a few corner cases I've missed. Should be ready in a few hours.

@mmazur mmazur force-pushed the kubevirt_vm_new_logic branch 2 times, most recently from bc5a2a6 to af65797 Compare April 3, 2019 10:24
@mmazur
Copy link
Contributor Author

mmazur commented Apr 3, 2019

And done. I'll go write a playbook for our repo to make sure all the corner cases I currently have in my head are actually properly tested and verified working

@pkliczewski
Copy link

👍

@mmazur
Copy link
Contributor Author

mmazur commented Apr 3, 2019

Ok, so kubevirt/ansible-kubevirt-modules#218 contains a comprehensive list of all the stuff this code does and tests for whether it does them correctly. That whole playbook passes on my system. So as far as I can tell this code is correct. Please add shipits and let's wait for someone to merge.

@pkliczewski
Copy link

+1

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 3, 2019
@gundalow
Copy link
Contributor

gundalow commented Apr 3, 2019

@mmazur Can you please rebase looks like one of the PRs I've just merged has caused a conflict
After rebase we will need shipit adding again to get label/shipit which is what triggers someone to merge, thanks

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Apr 3, 2019
@mmazur
Modify kubevirt_vm crud/wait logic
6949ac2 
1. Adds proper wait support for VM stops and starts
2. Detect kubevirt/ansible-kubevirt-modules#177
   and return a sane error
3. Switch to openshift-restclient 0.9.x style wait code
@mmazur
Copy link
Contributor Author

mmazur commented Apr 4, 2019

@machacekondra @pkliczewski had to rebase, please +1 again

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 4, 2019
@pkliczewski
Copy link

+1

@gundalow gundalow merged commit d8bddc0 into ansible:devel Apr 4, 2019
@gundalow
Copy link
Contributor

gundalow commented Apr 4, 2019

Thanks for the quick rebase.

Merged into devel for release in Ansible 2.8

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkliczewski pkliczewski pkliczewski left review comments

@machacekondra machacekondra machacekondra left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmazur @ansibot @pkliczewski @gundalow @machacekondra